matrix-org / matrix-bifrost

General purpose bridging with a variety of backends including libpurple and xmpp.js
Apache License 2.0
164 stars 31 forks source link

xmpp user with multiple devices keeps repeating "changed their display name" #280

Open emorrp1 opened 3 years ago

emorrp1 commented 3 years ago

Describe the bug I didn't report this at the time, as we can't identify the root cause, but it's now been independently confirmed in a completely different room. You can see from this public conversation (and older) that one user keeps rotating between poVoq/kris, when they've tried to set their display name in the ordinary way on the XMPP side.

My guess is that this is actually to do with Presence, and there's something going on with XMPP's equivalent of /away messages, but that's completely unfounded, sorry for the lack of Reproduction steps. Besides, these messages are simply annoying to see constantly in Element clients.

matrix.org offers an xmpp bridge that you can connect to as any other xmpp MUC. I just got reports that my nick kept cycling between detrout/diane over and over and I'm not really sure why

Expected behavior An XMPP user's preferred display name, when different from their JID should be stable until they manually change it. One workaround that appears to work is for them to set the display name to be equal to their JID user part.

detrout commented 3 years ago

I also had the problem and I wasn't sure if it was JID != nick or if I had multiple clients connected to the bridge and I had different nicks set in the different clients.

dora71 commented 2 years ago

Although this bug is already older, the problem still persists. Can confirm it with blabber.im Messenger (XMPP) and various Matrix rooms. Will test if the workaround is ok here.

ple1n commented 2 years ago

image

@_xmpp_blumedesdevils=40yax.im:matrix.org

I have seen this issue in different rooms. It persists.

Half-Shot commented 1 year ago

Yeah, this looks like it's basically picking the device name and bouncing between them. We should probably just pick a device name and stick to it.

endorxmr commented 1 year ago

I don't know if this is the same issue or not, but there are two xmpp users in a bridged room that keep spamming a ton of name changes/leave/rejoin events. Even with notifications disabled, it's getting extremely annoying and it's spamming the room a lot.

xmpp_rejoining_1 xmpp_rejoining_2
MichaelSasser commented 1 year ago

We would kindly appreciate, if this issue could be resolved or at least mitigated. We have a large room with 12.5k users and get asked a lot about XMPP user's name bouncing as well as the joining/leaving and if we could "just ban them" as this would be "annoying" and "frustrating". We are trying to be inclusive and welcoming to all of our users in the same way, but this issue becomes unbearable. Our "top XMPP user" currently generates 500 membership events per week (see graph below). Therefore, we are leaning towards temporarily banning XMPP users who generate a high number of state events until this issue is resolved, even though we don't want to.

Please do something.

XMPP membership events


Room: !iuyQXswfjgxQMZGrfQ:matrix.org

Neustradamus commented 1 year ago

Have you progressed on this ticket?