search

matrix-org / matrix-bifrost

General purpose bridging with a variety of backends including libpurple and xmpp.js
Apache License 2.0
162 stars 31 forks source link

Catch more gateway errors #355

Closed Half-Shot closed 9 months ago

Half-Shot commented 9 months ago

Some of our promises around gateways were not being awaited, which is dangerous.

Half-Shot commented 9 months ago

Looks fine, though does this suggest that something inside all of these GatewayHandler methods should be catching errors? Perhaps getVirtualRoom?

Very much agree. We've got issues where we get unexpected responses from homeservers and we aren't gracefully handling them. Though I think for a start we should stop the thing crashing.