search

matrix-org / matrix-bifrost

General purpose bridging with a variety of backends including libpurple and xmpp.js
Apache License 2.0
164 stars 31 forks source link

XMPP - can't leave room #53

Open licaon-kter opened 5 years ago

licaon-kter commented 5 years ago

...as even if the user deletes the bookmark and closes the room, the bridge sends a groupchat message that will open up the unwanted chat, basically SPIM.

Client side: https://github.com/siacs/Conversations/issues/3392

ejabberd log: https://gist.github.com/9d2601e0acefe836582aa73528f1d785

Temporary "solution": block domain and/or whole room in server s2s/c2s

Half-Shot commented 5 years ago

I'm assuming this a gateway bug?

jkasun commented 5 years ago

Is this issue is a good first issue to get started?

Half-Shot commented 5 years ago

Errrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrrm probably not, it's likely to be complicate :(

licaon-kter commented 5 years ago

ejabberd blocking the whole bridge server:

s2s_access: s2s
acl:
  ...
  blocked_servers:
    server:
      - "bridge.xmpp.matrix.org"

access_rules:
  ...
  s2s:
    - deny: blocked_servers
    - allow

But my server log is full of:

[info] <0.5903.0>@ejabberd_s2s_in:handle_auth_success:181 (tls|<0.5903.0>) Accepted inbound s2s EXTERNAL authentication bridge.xmpp.matrix.org -> mydomain.tld (hidden_by_ejabberd)
[info] <0.5903.0>@ejabberd_s2s_in:process_closed:131 Closing inbound s2s connection bridge.xmpp.matrix.org -> mydomain.tld: Stream closed by local host: invalid-from

And my ghosts are stuck in the room: hotelbridgetonia

Fun stuff, the [cnvrs] user didn't even manage to actually join, more info here: https://github.com/conversejs/converse.js/issues/1459

@Half-Shot Plenty of commits in the mean time, some sound useful, they are not deployed yet?

licaon-kter commented 4 years ago

Still an issue with the restarted bridge.

eeeeeta commented 4 years ago

I also ran into this; I had to "solve" the problem with a swift

$ sudo iptables -I INPUT -p tcp -s 94.237.52.46 -j REJECT

(where that IP is lethe.matrix.org). While it works, this solution isn't ideal...

ara4n commented 4 years ago

irritating that the ejabberd log gist has been deleted. i've just tried to repro this with Adium and can't; parting the room seems to part the user correctly, and the MUC doesn't continue to relay messages after having parted.

Anyone know what's the difference is between libpurple parting a MUC and conversations?

licaon-kter commented 4 years ago

@ara4n The gist disappearing must of been a cleaning mistake.

Half-Shot commented 4 years ago

I believe this is fixed in #144

licaon-kter commented 4 years ago

@Half-Shot do ping when that is actually deployed on the actual bridge, so we can test

auscompgeek commented 4 years ago

I just got myself stuck in Hotel California today. I understand that fix has been running on matrix.org for a while now.

Half-Shot commented 4 years ago

Yep, which room @auscompgeek ?

bqv commented 3 years ago

Apparently still an issue, reports from xmpp users of issues

bqv commented 3 years ago

@Half-Shot this needs to be fixed. I was on the fence before, but this is unusably frustrating...

allnamesaretakeningithub commented 3 years ago

I can confirm I cannot leave a matrix room

bqv commented 3 years ago

Forget it. Matrix/NewVector dont care about XMPP users. Remember that this is a corporate venture, and our experiences/opinions arent profitable. This will never be fixed.

Admicos commented 3 years ago

this is still a thing, and as a result i keep getting notifications and messages from places i quite like to not be in anymore.

is there any workaround that doesn't involve just rejecting matrix network packets? i have some other matrix groups i want to be in on

mrusme commented 3 years ago

Can't leave a room that hasn't been active anymore since August this year. I believe the room was either removed or something else happened, however, it's called xfz (Discord) and 6339 others now and when I try to leave it the Matrix desktop client tells me that...

myusername:matrix.org not in room !yhqiEdqNjyPbxtUjzm:matrix.org.
allnamesaretakeningithub commented 3 years ago

Since this bug is still affecting XMPP users I propose to change the name of the bridge to "Hotel California".

haansn08 commented 3 years ago

Can confirm this issue exists. Adding the room JID to the blocklist seems to be the only solution for now. Also had delivery problems, in a sense that there was no indication if my message was actually sent to the room or not.

maranda commented 3 years ago

That is fixed and live on aria-net.org's Bifrost by way.

allnamesaretakeningithub commented 3 years ago

That is fixed and live on aria-net.org's Bifrost by way.

@maranda and is there a merge request for this repo?

maranda commented 3 years ago

Waiting to know about the fate of another PR, before I open more

bqv commented 3 years ago

@Half-Shot take heed? Your work has been done for you :)

Unless of course @ara4n is instructing you to leave this broken... guess we'll find out!

Neustradamus commented 2 years ago

@Half-Shot, @ara4n: Have you taken a little time to look @maranda PR?