search

matrix-org / matrix-bifrost

General purpose bridging with a variety of backends including libpurple and xmpp.js
Apache License 2.0
162 stars 31 forks source link

Strange list of adhoc commands #68

Open contrapunctus-1 opened 5 years ago

contrapunctus-1 commented 5 years ago

I joined #fdroid#matrix.org@bridge.xmpp.matrix.org using Gajim, opened the adhoc commands menu ("Execute command") for the channel, and got this -

Screenshot_2019-04-07_02-37-19

XML console output when performing this operation - https://gist.github.com/contrapunctus-1/f8ab36b1897a6a25b766bee18ff6c629

Half-Shot commented 5 years ago

Very interesting. That's clearly the list of rooms from the public room list, but it looks like we are responding to a commands request with a list of rooms :(

eeeeeta commented 4 years ago

This'll be because XEP-0050 uses the whole disco#items stuff to get a list of adhoc commands. The fix would be to check the node attribute of the <query> element, and not send any items if it's an adhoc command query instead of just a room list query.