search

matrix-org / matrix-conf-website

Other
0 stars 6 forks source link

display link to pretix if cross domain js is disabled #33

Closed HarHarLinks closed 4 months ago

HarHarLinks commented 4 months ago

i block cross domain js by default (umatrix extension), which results in image

thibaultamartin commented 4 months ago

Interesting, the noscript tag doesn't work here? If this doesn't do the trick, I'm not sure how to fix it

HarHarLinks commented 4 months ago

i think was happens is

  1. js is enabled, so noscript tag isnt hit
  2. the request for the xsite js fails e.g. as if the site was down
  3. there's nothing to handle this case
thibaultamartin commented 4 months ago

Alright that seems to be a fairly niche use case, that only uMatrix users will stumble upon. The uMatrix has been archived in 2021, and I'm fairly sure uMatrix users are used to websites breaking when they block content.

If there's a quick and simple solution, happy to merge it, but I don't think it's the best use of our time to spend too many cycles on this right now