search

matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.
77 stars 17 forks source link

Add support for TLSv1.3 #100

Closed ilmari closed 4 years ago

ilmari commented 4 years ago

This requires bumping the minimum Go version to 1.12

Closes #97

richvdh commented 4 years ago

looks plausible, but it also looks like the CI is broken, so we might have to fix that first :/

ilmari commented 4 years ago

@richvdh adding GO111MODULE=on fixed the prerequisite installation step, but I have no idea how to fix the linter not finding the prereqs.

richvdh commented 4 years ago

It'd be good to make fixing the CI a separate PR.

ilmari commented 4 years ago

@richvdh It looks like gometalinter just doesn't work with go 1.11 modules. It's been deprecated and archived nearly a year ago. Apparently one should switch to golangci-lint.

I don't have the time nor the knowledge to do the conversion, but I think it would be a shame to block this change on that. Could we just disable the linting part of the CI for now, or merge this change regardless?

maquis196 commented 4 years ago

I've tried to migrate to golangci (keeping the versioning the same to just at least migrate before adding 1.13), but its hitting an issue, someone who knows go able to check whats going on here? https://github.com/matrix-org/matrix-federation-tester/pull/107

maquis196 commented 4 years ago

So my branch has been merged, if you want to rebase and give this a go again

ilmari commented 4 years ago

Thanks @maquis196! I've rebased it and it's all green! Fancy merging it, @babolivier?