search

matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.
77 stars 17 forks source link

Invalid server name in .well-known reports `FederationOK: true` #106

Open auscompgeek opened 4 years ago

auscompgeek commented 4 years ago

For example when https:// is in m.server, an Error will be correctly reported "Invalid server name 'https://...' in .well-known result", but FederationOK will be true.

richvdh commented 4 years ago

I believe that's correct behaviour. A malformed .well-known file is ignored by the protocol.

https://matrix.org/docs/spec/server_server/r0.1.3#resolving-server-names:

The schema of the /.well-known request is later in this section. If the response is invalid (bad JSON, missing properties, non-200 response, etc), skip to step 4.

richvdh commented 4 years ago

hrm, I suppose "the m.server property is there, but its content is invalid" isn't really covered by that - and it's probably also not what synapse does.

auscompgeek commented 4 years ago

Hmm, even if the well-known should be ignored, the rest of the report is empty too.

aaronraimist commented 3 years ago

This also causes the GUI to not show any errors even if matrix-federation-tester's json report shows Invalid server name.

richvdh commented 1 year ago

I wonder if this is still an issue