matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.
80 stars 17 forks source link

federation tester incorrectly says it times out when .well-known has a time-out, but an SRV record is present #113

Open mvgorcum opened 3 years ago

mvgorcum commented 3 years ago

Describe the bug Unclear error message when .well-known lookup has a time-out.

To Reproduce Run federation tester on a server that has SRV domain delegation, and a time-out on https://server_name/.well-known/matrix/server

Expected behavior I expected the federation tester to tell me the server works correctly, and optionally to mention a time-out on the .well-known lookup.

The tester gives a time-out error, but it doesn't clearly state that .well-known has a time-out:

Got 1 connection report.

There was an error looking up homeserver version information: Get matrix://balsillie.net/_matrix/federation/v1/version: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)

I would say it's technically correct, but hard to interpret. Screenshots image

Bubu commented 3 years ago

The json report correctly mentions that the well-known request timed out (in addition to the confusing general matrix:// timeout report). But this is apprently not surfaced to the frontend:

image

aaronraimist commented 3 years ago

This repo is just the federation tester itself, which provides the JSON output. The federationtester.matrix.org UI is on https://github.com/matrix-org/fed-tester-ui

Bubu commented 3 years ago

Right, this is a separate frontend issue as well for not reporting the well known error at all. But the json output produces the misleading timeout on federation request in the first place. (The timeout only happens on the well-known).

nrgill28 commented 1 year ago

Same issue happens on my homeserver. I also have an SRV record setup pointing to my matrix subdomain on port 8448, but the federation tester seems to be trying to make this request over port 443 which I don't have open and it causes a timeout.

https://federationtester.matrix.org/#hobscrk.space https://matrix.hobscrk.space:8448/_matrix/federation/v1/version