The API shape changed for GMSL in matrix-org/gomatrixserverlib#304 to allow us to control whether gomatrixserverlib.Client performs well-known/SRV lookups or not. The gomatrixserverlib.FederationClient defaults to enabled for this but gomatrixserverlib.Client does not.
So it is right after all to pass in the vanity name to GetVersion, but if the client isn't configured to look up well-known, it'll obviously do the wrong thing.
The API shape changed for GMSL in matrix-org/gomatrixserverlib#304 to allow us to control whether
gomatrixserverlib.Client
performs well-known/SRV lookups or not. Thegomatrixserverlib.FederationClient
defaults to enabled for this butgomatrixserverlib.Client
does not.So it is right after all to pass in the vanity name to
GetVersion
, but if the client isn't configured to look up well-known, it'll obviously do the wrong thing.Fixes #128.