search

matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.
77 stars 17 forks source link

Add `/api/federation-ok` endpoint #132

Closed stoically closed 1 year ago

stoically commented 1 year ago

Resolves #131

stoically commented 1 year ago

Force-push makes the linter happy (hopefully).

stoically commented 1 year ago

Force-push adjusts to the review comments accordingly.

(Disclaimer: First time writing Go, so, sorry if I'm doing unconventional stuff)

stoically commented 1 year ago

Force-push upper-cases the boolean text response.

babolivier commented 1 year ago

@stoically Please push normally once review has started on a PR as force-pushing makes figuring out what has changed since the previous review much more difficult. We squash merge PRs so it will end up as a single commit in the main branch anyway.

stoically commented 1 year ago

@babolivier Sure, I can do that. I wonder tho, why is it much more difficult? There's a "compare" button for the force-push?

(Also it'd be great if GitHub would just provide the feature of not allowing force-pushes for PRs in a repository, because preferences in that regard differ. But oh well)

richvdh commented 1 year ago

I wonder tho, why is it much more difficult? There's a "compare" button for the force-push?

I can't write comments on the "compare" view, so I have to juggle three separate views.

richvdh commented 1 year ago

Sorry, one last thing before we merge this. Please could you sign off that you have the right to contribute this work by adding a "Signed-off-by" comment to this PR, as described at https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off?

stoically commented 1 year ago

Signed-off-by: stoically <stoically@proprietary.lol>

richvdh commented 1 year ago

Sorry, but we do need a legally-recognised name. If you'd prefer to keep your details private, you can provide them to the matrix.org foundation as per https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#private-sign-off.

stoically commented 1 year ago

Signed-off-by: Johannes Becker <stoically@proprietary.lol>

(I really wonder how that can be a requirement, given I'm not giving any proof that's my actual name. I could just give any random name)

richvdh commented 1 year ago

I could just give any random name)

I hope you have not :)

stoically commented 1 year ago

Thanks for review and merge!

Out of curiosity, is it possible to check somewhere which version of the federation tester is deployed on https://federationtester.matrix.org?

I hope you have not :)

I didn't.

richvdh commented 1 year ago

Out of curiosity, is it possible to check somewhere which version of the federation tester is deployed on https://federationtester.matrix.org/?

not easily, no. It's currently v0.4.