search

matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.
78 stars 17 forks source link

Improve error handling, especially wrt .well-known checks #52

Closed babolivier closed 5 years ago

babolivier commented 5 years ago

This PR shows whether a /.well-known/matrix/server file exists for a server as a boolean rather than an error. It also removes the per-address WellKnownInUse value, which doesn't really make sense. Because that was the only value in ConnectionReport.Info, I also removed that structure. We might want to re-add it in the future if we have useful information to add there.

It also replaces error strings with instances of ReportError in order to handle errors the same way throughout the whole report.

Fixes #50 Fixes https://github.com/matrix-org/fed-tester-ui/issues/1

babolivier commented 5 years ago

FTR CI fails because https://github.com/matrix-org/gomatrixserverlib/pull/116 isn't merged yet. Will need to update the vendored gomatrixserverlib once that's done.

anoadragon453 commented 5 years ago

FYI foks will need to update the UI if this goes through.

richvdh commented 5 years ago

It also replaces error strings with instances of ReportError in order to handle errors the same way throughout the whole report.

I am unconvinced this is the right thing to do.

anyway, blocking this pending updates to https://github.com/matrix-org/gomatrixserverlib/pull/116

babolivier commented 5 years ago

Superseded by https://github.com/matrix-org/matrix-federation-tester/pull/70