matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.
78 stars 17 forks source link

Add homeserver version information to report #67

Closed anoadragon453 closed 5 years ago

anoadragon453 commented 5 years ago

Adds a new field, Version, with fields Name, Version and Error, fields being omitted if they're nil.

Output for a server which supplies version information (Synapse):

  "Version": {
    "name": "Synapse",
    "version": "0.99.1.1"
  }

Output for when no version information is supplied by the homeserver:

  "Version": {
    "error": "No version information was found for this server"
  }

Fixes #48

aaronraimist commented 5 years ago

Fixes #48

richvdh commented 5 years ago

Output for when no version information is supplied by the homeserver:

by which you mean, the server returns a 4xx/5xx? It is not an error for a server to return an empty response here.

anoadragon453 commented 5 years ago

@richvdh Would it be better if the JSON key were info: instead of error:?