Return an error if server_name is missing

matrix-org / matrix-federation-tester

Tester for matrix federation written in golang.

78 stars 17 forks source link

Return an error if server_name is missing #77

Closed babolivier closed 5 years ago

babolivier commented 5 years ago

Fixes #65

babolivier commented 5 years ago

I'm not convinced we should send error responses as json - why not just send the plain text?

Because I thought it would make it easier for people building on top of the federation tester if we use an existing JSON property instead of making special cases in which the federation tester would not follow the response schema it follows for every other requests, as long as possible.