search

matrix-org / matrix-hookshot

A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA.
https://matrix-org.github.io/matrix-hookshot/
Apache License 2.0
290 stars 68 forks source link

Use `URL`s instead of strings for config values #564

Open AndrewFerr opened 1 year ago

AndrewFerr commented 1 year ago

Using strings to hold user-defined URL configurations is a bit unwieldy. They should instead be URLs to allow some nicer processing on them (or maybe even some external URL-parsing library can be used, as URL is finicky in its own ways).

AndrewFerr commented 1 year ago

One convenience that should come with this (or at least be done at the same time) is to remove trailing URL slashes anywhere they cause a problem, such as the !hookshot gitlab project command.