matrix-org / matrix-hookshot

A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA.
https://matrix-org.github.io/matrix-hookshot/
Apache License 2.0
293 stars 68 forks source link

Fix crash from exceptions in handlers #771

Closed justinbot closed 1 year ago

justinbot commented 1 year ago

Fixes the whole application crashing when an exception happens in a handler. Typically this was failing to send a message due to lacking permissions.

This seems like it may have regressed in #754 due to changes wrapping in Sentry.withScope, which has this caveat:

Any exceptions that occur within the callback function for withScope will not be caught, and all errors that occur will be silently ignored and not reported.

Fixes #769