search

matrix-org / matrix-hookshot

A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA.
https://matrix-org.github.io/matrix-hookshot/
Apache License 2.0
283 stars 68 forks source link

Add toggle for bridge queue config #775

Open Arkaniad opened 1 year ago

Arkaniad commented 1 year ago

With the 2.6.0 release it looks like worker support with Redis was configured. With the Helm Chart using the default configuration, the values.yaml has a configured queue block since it's in the config.sample.yml file.

Given that the chart doesn't yet deploy Redis, this results in a broken config by default unless .Values.hookshot.config.queue is set to {} as user-specified values will be merged on top of chart default values.

This will also break user configurations if they set up shop using the config.sample.yml file as it exists prior to this commit.

We're just adding an enabled flag to the queue config key and defaulting it to false - That way Hookshot should never expect a Redis service to be available unless explicitly configured and enabled.

Arkaniad commented 1 year ago

Your system linter appears to have gone to town :p

Is there a special invocation I need to make it match up with your conventions or are they not in the repo? I think I just have blanket auto formatting on everything in VSCode somehow...