search

matrix-org / matrix-hookshot

A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA.
https://matrix-org.github.io/matrix-hookshot/
Apache License 2.0
283 stars 68 forks source link

Upon subscribing to a feed, fetch the latest entry #806

Open HarHarLinks opened 1 year ago

HarHarLinks commented 1 year ago

As a user of feeds, I am used to my reader fetching and showing me at least the couple latest entries in the feed. Hookshot however just subscribes, and only posts new posts that appear from that point on.

I suggest changing the behavior such that upon subscribing, hookshot posts the latest entry in the feed.

Half-Shot commented 1 year ago

I must admit I've heard the feedback over and over that it's weird that it does nothing on subscribe. I agree fetching the first item sounds sane.

tadzik commented 1 year ago

This'd come with an odd side-effect when Redis is not in use.

Redis is currently used as a storage for already seen feed entries. If not configured, we store those in memory, and forget them on every restart. Then, when feeds are checked for the first time on startup, we assume to be doing the "initial sync", and we don't report feed items.

With this change in, hookshot would, on startup, (re)post the latest feed item for every feed to every room. We could make this feature configurable, but perhaps it'd be smarter for FeedReader to detect if it's running in non-persistent mode and figure it out by itself.

bkil commented 1 year ago

Somewhat related #768