matrix-org / matrix-hookshot

A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA.
https://matrix-org.github.io/matrix-hookshot/
Apache License 2.0
283 stars 68 forks source link

Ensure all forms of request failure on a feed are not treated as a parsing failure by metrics #816

Closed Half-Shot closed 1 year ago

Half-Shot commented 1 year ago

Things like TLS fails and timeouts were coming through as parsing failures, which is unfortunate because it was incorrectly highlighting a bug with our parser.

We also ensure that a lpush is not attempted with a empty array.