Feeds aren't treated as initial synced until a feed item is read, so the first item in a previously empty feed is skipped.

matrix-org / matrix-hookshot

A bridge between Matrix and multiple project management services, such as GitHub, GitLab and JIRA.

https://matrix-org.github.io/matrix-hookshot/

Apache License 2.0

293 stars 68 forks source link

Feeds aren't treated as initial synced until a feed item is read, so the first item in a previously empty feed is skipped. #893

Open Half-Shot opened 9 months ago

Half-Shot commented 9 months ago

Found via https://github.com/matrix-org/matrix-hookshot/issues/844#issuecomment-1936584635. This is because we create a list of read guids from the items we have read, but that list is only created after we have read at least one item. See https://github.com/matrix-org/matrix-hookshot/blob/0bc49c2f2a87176c25d4be96977e076c81108376/src/feeds/FeedReader.ts#L272-L275

Probably would be fixed by #806

bkil commented 9 months ago

The same thing happened with the exact same feed. The new entry from 8 hours ago was skipped. Would you like to improve the issue description to also encompass such a case, or should we open a different issue for this?

bkil commented 9 months ago

Sorry, the issue minutes ago is not applicable, because this entry has since appeared after a delay. The previously mentioned entry is still missing, though.

bkil commented 9 months ago

It skipped an entry again