matrix-org / matrix-js-sdk

Matrix Client-Server SDK for JavaScript
Apache License 2.0
1.49k stars 578 forks source link

Element R: fix `isCrossSigningReady` not checking identity trust #4156

Closed BillCarsonFr closed 2 months ago

BillCarsonFr commented 2 months ago

Fix an inconsistency between legacy crypto and rust crypto when calling isCrossSigningReady. Legacy is checking that cross-signing is set up and that the keys are trusted. Rust was just checking that cross-signing was set up.

Related issue https://github.com/element-hq/customer-retainer/issues/224

Checklist

richvdh commented 2 months ago

@BillCarsonFr It would be good to summarise what effects this bug might have on the user experience. IIRC we have at least one bug report which we believe was caused by this? But it doesn't seem to be linked.

BillCarsonFr commented 2 months ago

@BillCarsonFr It would be good to summarise what effects this bug might have on the user experience. IIRC we have at least one bug report which we believe was caused by this? But it doesn't seem to be linked.

added in description