matrix-org / matrix-js-sdk

Matrix Client-Server SDK for JavaScript
Apache License 2.0
1.56k stars 583 forks source link

RoomAvatarEventContent shouldn't reuse ImageInfo #4244

Closed Johennes closed 3 months ago

Johennes commented 3 months ago

ImageInfo extends from FileInfo which includes bits for encrypted files. However, m.room.avatar is a state event. So encrypting it is pointless because room state itself is not encrypted.

See also https://github.com/matrix-org/matrix-spec/issues/562 and https://github.com/ruma/ruma/issues/397.