At least one dependency doesn't support ES modules

matrix-org / matrix-js-sdk

Matrix Client-Server SDK for JavaScript

Apache License 2.0

1.6k stars 589 forks source link

At least one dependency doesn't support ES modules #4317

Open lukasz-zaroda opened 3 months ago

lukasz-zaroda commented 3 months ago

It looks like this package doesn't fully support ESM because at least one of its dependencies doesn't support it. I mean sdp-transform here. Maybe for bundlers it doesn't matter, but it's impossible to use this lib in a pure ESM environment, like with a Symfony's AssetMapper.

richvdh commented 3 months ago

Isn't https://github.com/matrix-org/matrix-js-sdk/issues/4287 more of a problem for an ES environment?

lukasz-zaroda commented 3 months ago

Isn't #4287 more of a problem for an ES environment?

Possibly. I couldn't even require this library in AssetMapper, though, because it failed on the sdp-transform library when figuring out dependencies, so it's possible that even if sdp-transform would not be a problem, I would stumble on something else later. These issues are not mutually exclusive.