`createClient` should set up `sessionStore`

matrix-org / matrix-js-sdk

Matrix Client-Server SDK for JavaScript

Apache License 2.0

1.53k stars 580 forks source link

`createClient` should set up `sessionStore` #863

Open jryans opened 5 years ago

jryans commented 5 years ago

Currently the JS SDK requires both sessionStore and cryptoStore for E2E to work properly, but the createClient helper only creates 1 out of 2, leading to various confused reports as to why E2E doesn't work.

cedricvanrompay commented 5 years ago

It seems that this was in the roadmap at least at some point, according to documentation of MatrixClient:

The createClient helper will not create this store at the moment.

source: https://github.com/matrix-org/matrix-js-sdk/blob/6979177fb27352059d85e74dd80e7eb129595197/src/client.js#L117

jryans commented 5 years ago

Ah, I added that comment last month when I was surprised by it not happening by default. 😁