search

matrix-org / matrix-react-sdk-module-api

API surface for writing Modules for the react-sdk
Apache License 2.0
3 stars 8 forks source link

Add prettier #18

Closed dhenneke closed 1 year ago

dhenneke commented 1 year ago

This PR aligns the code formatting to the other projects to make it easier to work with the code.

weeman1337 commented 1 year ago

I am trying to figure out what to do about Node 14: https://matrix.to/#/!bEWtlqtDwCLFIAKAcv:matrix.org/$5Xdul9sib5y7FWTxJXoQhQ3wWt9YMiscF56oOGjnzYk?via=matrix.org&via=element.io&via=envs.net

dhenneke commented 1 year ago

I added eslint-plugin-unicorn because eslint complained that it wasn't installed.

weeman1337 commented 1 year ago

I added eslint-plugin-unicorn because eslint complained that it wasn't installed.

Yep. It is a peer dependency of eslint-plugin-matrix-org . Depending on the configuration it has to be installed.

dhenneke commented 1 year ago

I rebased the branch (the formatting changes made it hard to update it) and also upgraded the pipeline to use matrix builds for node 18 & latest. If you prefer, I can also move the pipeline part to a separate PR.

weeman1337 commented 1 year ago

The workflows are still failing. @dhenneke can you use the same as in https://github.com/matrix-org/matrix-react-sdk/blob/develop/.github/workflows/static_analysis.yaml#L70 etc.?

dhenneke commented 1 year ago

Yes I will update the actions later 👍

richvdh commented 1 year ago

@weeman1337 will you merge this?

weeman1337 commented 1 year ago

@weeman1337 will you merge this?

I've just learned, that „You’re not authorized to merge this pull request.“ @richvdh can you merge it?