Closed Velin92 closed 12 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
827ae99
) 89.94% compared to head (6ace558
) 89.91%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SGTM
I might improve it tomorrow, since I was able to run it locally in El-X at the end
Kudos, SonarCloud Quality Gate passed!
Since the NSTextAttachmentProvider can only see the text view, and the pill might require a context that holds various data and helpful functions to make the pill render correctly, this is just a markdown protocol that can be injected as a weak var to get such context.
For example on Element X this context could be the room context, useful to get all the informations of the already fetched members, and the image provider.
The using application will already know what type the context is and just type unwrap it.
Also added a flushPills function on the textview