matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
92 stars 23 forks source link

Android: handle all `ClickableSpans` in the gesture detector #895

Closed jmartinesp closed 10 months ago

jmartinesp commented 10 months ago

While testing the latest version on EX Android I realised auto-linkified links (using URLSpan) weren't clickable since the gesture detector ignored them. This fixes the issue.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (65b72e2) 87.41% compared to head (ed4b1ed) 87.28%.

Files Patch % Lines
...io/element/android/wysiwyg/EditorStyledTextView.kt 50.00% 0 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #895 +/- ## ============================================ - Coverage 87.41% 87.28% -0.14% - Complexity 409 415 +6 ============================================ Files 166 134 -32 Lines 18974 17387 -1587 Branches 1046 408 -638 ============================================ - Hits 16587 15177 -1410 + Misses 2089 1935 -154 + Partials 298 275 -23 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `65.92% <50.00%> (-5.15%)` | :arrow_down: | | [uitests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `65.92% <50.00%> (+0.21%)` | :arrow_up: | | [uitests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `86.57% <ø> (+1.11%)` | :arrow_up: | | [unittests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `44.94% <ø> (ø)` | | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information