search

matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
83 stars 19 forks source link

Fix for dictation not working on iOS 17 #922

Closed Velin92 closed 5 months ago

Velin92 commented 5 months ago

This should fix the issue for all iOS versions, since we are relying on a specific keyboard notification to intercept the state

fixes #921

codecov-commenter commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9a8cb9c) 87.39% compared to head (8e9a00f) 89.58%.

Files Patch % Lines
...mponents/WysiwygComposerView/WysiwygTextView.swift 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #922 +/- ## ============================================ + Coverage 87.39% 89.58% +2.19% ============================================ Files 167 118 -49 Lines 19063 16917 -2146 Branches 1044 612 -432 ============================================ - Hits 16660 15155 -1505 + Misses 2096 1738 -358 + Partials 307 24 -283 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `79.04% <40.00%> (+8.37%)` | :arrow_up: | | [uitests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [uitests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `79.04% <40.00%> (+0.14%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `88.26% <40.00%> (+2.70%)` | :arrow_up: | | [unittests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `75.93% <40.00%> (+0.13%)` | :arrow_up: | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/922/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.50% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud