search

matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
83 stars 19 forks source link

Remove NBSP chars in `replace_text` for empty paragraphs #926

Closed jmartinesp closed 5 months ago

jmartinesp commented 5 months ago

This should fix the issue about the extra NBSPs being added when pasting text.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f0d503e) 87.40% compared to head (ad90ee5) 87.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #926 +/- ## ========================================= Coverage 87.40% 87.40% Complexity 424 424 ========================================= Files 167 167 Lines 19055 19055 Branches 1040 1040 ========================================= Hits 16655 16655 Misses 2093 2093 Partials 307 307 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `70.65% <ø> (-0.06%)` | :arrow_down: | | [uitests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.59% <ø> (-0.10%)` | :arrow_down: | | [uitests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `79.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `85.58% <100.00%> (-0.03%)` | :arrow_down: | | [unittests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `43.46% <ø> (ø)` | | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `75.93% <ø> (-0.26%)` | :arrow_down: | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.50% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bmarty commented 5 months ago

I confirm that the issue which was observed is gone with this. Thanks @jmartinesp !