matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
83 stars 19 forks source link

Android : fix touch handling on EditorStyledText #937

Closed ganfra closed 4 months ago

ganfra commented 4 months ago

The touch events were not handled correctly as it could lead to touch events being processed twice.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.50%. Comparing base (c53c372) to head (67c34f7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #937 +/- ## ========================================== + Coverage 88.23% 89.50% +1.27% ========================================== Files 118 86 -32 Lines 16935 15371 -1564 Branches 616 0 -616 ========================================== - Hits 14942 13758 -1184 + Misses 1964 1613 -351 + Partials 29 0 -29 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.50% <ø> (+1.27%)` | :arrow_up: | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.50% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

jmartinesp commented 4 months ago

There are some issues with the emulator and free space in the runner, which is kind of weird:

ERROR | Not enough space to create userdata partition. Available: 7272.484375 MB at /home/runner/.android/avd/../avd/test.avd, need 7372.800000 MB.

We'll have to look into it, it seems like it's this change.

Anyway, I think we can merge it as is.