matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
82 stars 19 forks source link

Simplify input connection code by using `InputConnectionWrapper`. #956

Closed jmartinesp closed 3 months ago

jmartinesp commented 3 months ago

Also reduce the number of times the selection changed listener is called.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.18%. Comparing base (2cb7265) to head (25116f1).

Files Patch % Lines
.../java/io/element/android/wysiwyg/EditorEditText.kt 0.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #956 +/- ## ============================================ + Coverage 86.24% 87.18% +0.94% + Complexity 448 447 -1 ============================================ Files 168 136 -32 Lines 19301 17712 -1589 Branches 1082 448 -634 ============================================ - Hits 16646 15443 -1203 + Misses 2326 1968 -358 + Partials 329 301 -28 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.61% <60.00%> (+0.14%)` | :arrow_up: | | [uitests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.61% <60.00%> (+0.14%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `86.44% <0.00%> (+0.88%)` | :arrow_up: | | [unittests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `42.09% <0.00%> (-0.04%)` | :arrow_down: | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud