matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
82 stars 19 forks source link

Android: make `RichTextEditorState.messageMarkdown` store pure markdown #970

Closed jmartinesp closed 2 months ago

jmartinesp commented 2 months ago

At the moment it contains some pseudo MD-HTML hybrid we could use to display mention pills, but we're not actually using right now AFAICT.

It's causing https://github.com/element-hq/element-x-android/issues/2214.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.26%. Comparing base (610d671) to head (9bb5c35).

Files Patch % Lines
...roid/wysiwyg/internal/viewmodel/EditorViewModel.kt 28.57% 2 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #970 +/- ## ============================================ - Coverage 88.48% 87.26% -1.22% - Complexity 446 449 +3 ============================================ Files 227 154 -73 Lines 23990 20129 -3861 Branches 750 753 +3 ============================================ - Hits 21228 17566 -3662 + Misses 2457 2255 -202 - Partials 305 308 +3 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.49% <37.50%> (-9.57%)` | :arrow_down: | | [uitests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.49% <37.50%> (-0.06%)` | :arrow_down: | | [uitests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `86.60% <0.00%> (-0.32%)` | :arrow_down: | | [unittests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `41.88% <0.00%> (-0.27%)` | :arrow_down: | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-react](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `87.99% <ø> (ø)` | | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.