matrix-org / matrix-rich-text-editor

Matrix Rich Text Editor
https://matrix-org.github.io/matrix-rich-text-editor/
Apache License 2.0
82 stars 19 forks source link

Android: fix selection mismatch on Android 14 after autocompletion #973

Closed jmartinesp closed 1 month ago

jmartinesp commented 1 month ago

This was caused by EditorInputAction.UpdateSelection not returning a ReplaceTextResult.

ReplaceTextResult was wrapped inside a ComposerResult sealed interface and the missing SelectionUpdated was added to it.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 36.11111% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 86.68%. Comparing base (8ebf48a) to head (7aac56a).

Files Patch % Lines
.../java/io/element/android/wysiwyg/EditorEditText.kt 19.04% 2 Missing and 15 partials :warning:
.../wysiwyg/inputhandlers/InterceptInputConnection.kt 0.00% 0 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #973 +/- ## ============================================ - Coverage 88.46% 86.68% -1.79% + Complexity 450 440 -10 ============================================ Files 227 154 -73 Lines 24018 20152 -3866 Branches 759 760 +1 ============================================ - Hits 21248 17468 -3780 + Misses 2457 2382 -75 + Partials 313 302 -11 ``` | [Flag](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.81% <36.11%> (-9.23%)` | :arrow_down: | | [uitests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `64.81% <36.11%> (+0.18%)` | :arrow_up: | | [uitests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.42% <ø> (+2.53%)` | :arrow_up: | | [unittests-android](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-ios](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `?` | | | [unittests-react](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `87.99% <ø> (ø)` | | | [unittests-rust](https://app.codecov.io/gh/matrix-org/matrix-rich-text-editor/pull/973/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org) | `89.64% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=matrix-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud