search

matrix-org / matrix-rust-sdk-crypto-nodejs

Apache License 2.0
3 stars 5 forks source link

Adds prebuilt library support for s390x #32

Closed mgcm closed 7 months ago

mgcm commented 8 months ago

This PR addresses the issue https://github.com/matrix-org/matrix-rust-sdk-crypto-nodejs/issues/24 by updating the release workflow to include an additional cross-compilation target and extending the download-lib.js file to handle this new architecture.

mgcm commented 8 months ago

The code looks good, but I can't test it though.

Does this mean we won't be able to bring this in? What would be the way forward?

Hywan commented 7 months ago

It's OK if I can't test it myself as soon as Github CI can test it I believe.

mgcm commented 7 months ago

In the meantime, I was able to contribute a patch to @napi-rs/cli that includes a missing check for s390x in the generated index.js template that was released a few days ago.

I have successfully built and have a successful test run of this PR in an IBM LinuxONE Community Cloud VM.

mgcm commented 7 months ago

This test failure for v19 doesn't seem to be related to the PR, right?