search

matrix-org / matrix-rust-sdk-crypto-nodejs

Apache License 2.0
3 stars 5 forks source link

Add bindings for room key backup & recovery #7

Closed AndrewFerr closed 1 year ago

AndrewFerr commented 1 year ago

This was adapted from https://github.com/matrix-org/matrix-rust-sdk/pull/2196/, which added key backup support to the JS bindings.

Note that this depends on matrix-rust-sdk being able to store backup keys.

AndrewFerr commented 1 year ago

This shouldn't be reviewed until https://github.com/matrix-org/matrix-rust-sdk/pull/2196 is, at which point I'll pull in any changes made during that review. I'll leave this PR as a draft until then.

AndrewFerr commented 1 year ago

https://github.com/matrix-org/matrix-rust-sdk/pull/2196 is now https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/pull/10, and is merged, so taking this out of draft.

AndrewFerr commented 1 year ago

Note that the WASM version of key backup support has settled down, so this PR should be ready to be merged.

AndrewFerr commented 1 year ago

TIL GitHub's rebase merges always make new commits instead of just fast-fowarding. For the sake of preserving the original branch, I'll just force push the PR branch to main (which is a zero-diff change), and will use either merge commits or local pushes from now on.

EDIT: never mind, the main branch is protected. I'll just take the L :upside_down_face:

poljar commented 1 year ago

You'll have to use merge-commits if you want to preserve the hashes and use GitHub's UI.