search

matrix-org / matrix-rust-sdk-crypto-wasm

Apache License 2.0
13 stars 7 forks source link

Update Rust SDK to latest version #134

Closed uhoreg closed 4 months ago

uhoreg commented 4 months ago

Looks like three different matrix-rust-sdk PRs introduced incompatible changes. This is my attempt to fix them. I'm certain that the fix for my PR is correct, but fairly sure that the sender_data fix is correct, and less sure that the CollectStrategy fix is sensible.

This introduces a change that will break js-sdk (yay for cascading breakage), so that will need to be updated.

~Not sure why the test is failing. Seems to be unrelated to the changes here, so must be some change elsewhere. I'm guessing that it should be fine to update the expected values to the actual values, but someone who knows about why the discrepancy is there should verify.~

richvdh commented 4 months ago

Fixes https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/pull/132

uhoreg commented 4 months ago

Could you update the changelog pls?

I've added a changelog. I'm not sure what the criteria are for which rust-sdk-crypto changes to highlight in the changelogs, so I just highlighted the one that causes the breaking change.