matrix-org / matrix-rust-sdk-crypto-wasm

Apache License 2.0
13 stars 7 forks source link

Update rust-sdk ver and `bootstrapCrossSigning` response #49

Closed richvdh closed 1 year ago

richvdh commented 1 year ago

bootstrapCrossSigning now returns its own type, which can contain two or three nested requests. Create a new response type wrapper and return it.

Some other cleanups while we are here:

bnjbvr commented 1 year ago

(I just thought that an alternative design would be to create a large promise wrapping the three others: if first is present, run it and mark it as sync; then run second; then run third — and expose only that large promise to JS. It would simplify the end user API.)

richvdh commented 1 year ago

(I just thought that an alternative design would be to create a large promise wrapping the three others: if first is present, run it and mark it as sync; then run second; then run third — and expose only that large promise to JS. It would simplify the end user API.)

I'm not really following this. We do need the details of the actual requests, because it's up to the JS side to actually make those requests over HTTP: rust-sdk-crypto-wasm itself does no networking.

bnjbvr commented 1 year ago

(I just thought that an alternative design would be to create a large promise wrapping the three others: if first is present, run it and mark it as sync; then run second; then run third — and expose only that large promise to JS. It would simplify the end user API.)

I'm not really following this. We do need the details of the actual requests, because it's up to the JS side to actually make those requests over HTTP: rust-sdk-crypto-wasm itself does no networking.

Ah yes, i lacked that context, nevermind me.