search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.2k stars 240 forks source link

ci: `test_room_preview` intermittently fails #3483

Open bnjbvr opened 3 months ago

bnjbvr commented 3 months ago

Full name: tests::sliding_sync::room::test_room_preview

See for instance: https://github.com/matrix-org/matrix-rust-sdk/actions/runs/9301293644/job/25599110490?pr=3482

bnjbvr commented 3 months ago 
2024-05-30T10:59:19.770340Z DEBUG send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10] config=RequestConfig { timeout: 30s, retry_limit: 3 } request_id="REQ-9" method=GET uri="http://localhost:8008/_matrix/client/unstable/im.nheko.summary/rooms/!xuNKJaTpATGsEqlRJj:synapse/summary" status=200 response_size="207 B"}: matrix_sdk::http_client: Got response
thread 'tests::sliding_sync::room::test_room_preview' panicked at testing/matrix-sdk-integration-testing/src/tests/sliding_sync/room.rs:1130:49:
called `Option::unwrap()` on a `None` value

This is happening only when using the MSC3266 endpoint, so I'm wondering if this isn't the remote that fails sending us the right data…

bnjbvr commented 3 months ago

https://github.com/matrix-org/matrix-rust-sdk/actions/runs/9353074646/job/25781614650 shows a failure with more logs. It's the final test using the known room path that fails, letting me think that it's because the sync got aborted a bit too soon. Let's see if #3504 fixes it.

bnjbvr commented 3 months ago

Amazing, the test failed again on main just on the merge commit.

https://github.com/matrix-org/matrix-rust-sdk/actions/runs/9367521404/job/25787376937

bnjbvr commented 3 months ago

If it turns out that https://github.com/matrix-org/matrix-rust-sdk/pull/3508 fixes the intermittent failure here, then the SDK might need changes too, because we might be missing some state events to determine the full RoomPreview for rooms we've joined.