search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.21k stars 240 forks source link

Authenticated medias: add a `ClientBuilder` option to force usage of authenticated media requests #3650

Closed bnjbvr closed 2 months ago

bnjbvr commented 3 months ago

See also https://github.com/matrix-org/matrix-rust-sdk/pull/3598/commits/a8a22866c57233d9b45dc14d8a307f8941332197#diff-f1125bfdfc76977d385ec6bc0299a01791d86fb478fb0160f7a472ebac2a9da0R276

poljar commented 3 months ago

Upon some discussion with our security guys, this isn't an issue since this is only about authentication to your own homeserver, and isn't part of our threat model.

So we should just remove the TODO since I'm not quite sure what threat I was thinking about.