matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.26k stars 252 forks source link

chore(ui,ffi): Remove the `RoomList::entries` method #3999

Closed Hywan closed 2 months ago

Hywan commented 2 months ago

This method is now private inside matrix_sdk_ui and removed from matrix_sdk_ffi. This method is returning a stream of rooms, but updates on rooms won't update the stream (only new rooms will be seen on the stream). Nobody uses it as far as I know, and entries_with_dynamic_adapters is the real only API we want people to use.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.28%. Comparing base (2532c52) to head (e03f0e6). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3999 +/- ## ========================================== - Coverage 84.29% 84.28% -0.02% ========================================== Files 266 266 Lines 28299 28299 ========================================== - Hits 23856 23853 -3 - Misses 4443 4446 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.