codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.24%. Comparing base (
abbe2ec) to head (19400fc). Report is 4 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #4005 +/- ## ========================================== - Coverage 84.25% 84.24% -0.01% ========================================== Files 266 266 Lines 28328 28328 ========================================== - Hits 23867 23865 -2 - Misses 4461 4463 +2 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes https://github.com/matrix-org/matrix-rust-sdk/issues/3931, or so I think: the test waits for a stable state where there aren't any new updates to the timeline, before trying to edit a timeline item, and observe a precise sequence of timeline updates after the item has been edited.
The failures showed that the stable state wasn't reached, because in some occasions, we'd receive the original text as a new timeline update — which could also be the sign of a failing server / duplicated event or other things, but I believe it is just that 1 second timeouts ain't enough for code running under CodeCov.