search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.26k stars 252 forks source link

sdk-base: split `handle_account_data` and `process_direct_rooms` #4010

Closed jmartinesp closed 1 month ago

jmartinesp commented 2 months ago

Follow up for https://github.com/matrix-org/matrix-rust-sdk/pull/3990.

This removes a couple of TODOs in the codebase where we were running handle_account_data twice to be able to update the direct rooms after the rooms had been created in the store. Now these responsibilities are split in two separate functions.

Signed-off-by:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (f576c72) to head (c2015f5). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/client.rs 95.23% 2 Missing :warning:
crates/matrix-sdk-base/src/sliding_sync/mod.rs 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4010 +/- ## ========================================== - Coverage 84.27% 84.26% -0.02% ========================================== Files 266 266 Lines 28336 28341 +5 ========================================== + Hits 23880 23881 +1 - Misses 4456 4460 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jmartinesp commented 1 month ago

Thanks for the comments, I think all those are fixed, so I'll merge it now.