search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.26k stars 252 forks source link

feat(base): Increase the `room_info_notable_update_sender` capacity #4013

Closed Hywan closed 2 months ago

Hywan commented 2 months ago

This broadcast channel can easily be overflowed if more than 100 updates arrive at the time. This patch extends the capacity to 2^16 - 1.

This patch also adds more logs to detect lagged on this channel from the room list point of view.

Hywan commented 2 months ago

I've removed the comments as suggested by @bnjbvr and I've used u16::MAX directly, without substrating 1.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 84.24%. Comparing base (f576c72) to head (f00bbf8). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/matrix-sdk-ui/src/room_list_service/room_list.rs 0.00% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4013 +/- ## ========================================== - Coverage 84.27% 84.24% -0.04% ========================================== Files 266 266 Lines 28336 28343 +7 ========================================== - Hits 23880 23877 -3 - Misses 4456 4466 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.