search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.2k stars 240 forks source link

Make `unreachable!` `ClientBuildError` assertion give a descriptive error #4016

Open reivilibre opened 1 week ago

reivilibre commented 1 week ago

...since I don't know why I'm getting this error, it only tells me I shouldn't be! :D

Signed-off-by: oliverw@element.io

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.26%. Comparing base (8119697) to head (26b1157).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4016 +/- ## ========================================== + Coverage 84.25% 84.26% +0.01% ========================================== Files 266 266 Lines 28344 28344 ========================================== + Hits 23880 23884 +4 + Misses 4464 4460 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reivilibre commented 1 week ago

I can have a go at that soon, will have to happen after the mad rush to get this other stuff done that led to this issue.

BTW it was a SqliteStore(MissingVersion).... :shrug: