search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.26k stars 252 forks source link

ffi: use fork of `tracing` crate with a fix for Android logs rotation #4038

Closed jmartinesp closed 1 month ago

jmartinesp commented 1 month ago

The tracing library has an issue that prevents the configured log rotation from working on Android. While there has been a proposed fix for some time, it hasn't been merged yet.

We recently discovered some cases of users who had hundreds of log files, several times our current max limit, and today I confirmed old logs weren't being deleted.

My proposed solution is to use a forked tracing library in the meantime, along with a forked paranoid-android one, which needs to use this former fork.

I tested this on an Android client and I saw the old logs being removed, as expected.

Signed-off-by:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.51%. Comparing base (322c5b3) to head (10a0b7e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4038 +/- ## ========================================== + Coverage 84.50% 84.51% +0.01% ========================================== Files 266 266 Lines 28475 28475 ========================================== + Hits 24062 24066 +4 + Misses 4413 4409 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jmartinesp commented 1 month ago

I think it should be ok after https://github.com/matrix-org/matrix-rust-sdk/pull/4038/commits/e7f51352d7d32b8b7ce1c09d9d09caa6aefefb73