search

matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.27k stars 253 forks source link

The matrix-sdk crate depends on the matrix-sdk-ffi-macros crate #4292

Open poljar opened 2 days ago

poljar commented 2 days ago

This dependency is breaking our release process since none of the crates in the /bindings folder are set up for the release process.

bnjbvr commented 2 days ago

The ffi-macros crate is used if the uniffi feature is set, right? So technically we do have to ship it, even though we don't ship the bindings, as long as we have the uniffi feature :thinking:

poljar commented 2 days ago

Well yes, that's what this issue is about, I released the macros crate manually this time around.

Though we can do a couple of things to fix this issue:

  1. Get rid of the dep.
  2. Add the ffi-macros to our release process.
  3. Upstream the feature the macro provides to uniffi.