matrix-org / matrix-rust-sdk

Matrix Client-Server SDK for Rust
Apache License 2.0
1.27k stars 253 forks source link

refactor: Clean up the Room::compute_display_name() method #4306

Closed poljar closed 1 day ago

poljar commented 1 day ago

This method has grown organically into a bit of a beast. Let's try to make it a bit easier to understand in preparation for MSC4171 :saluting_face:.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (d2f255d) to head (4379050). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/rooms/normal.rs 95.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4306 +/- ## ========================================== - Coverage 85.11% 85.08% -0.04% ========================================== Files 274 274 Lines 30184 30191 +7 ========================================== - Hits 25692 25688 -4 - Misses 4492 4503 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: