Closed pixlwave closed 4 months ago
... and because I haven't sent enough comments in the last few minutes: the deprecation requirements can be clarified concurrent to checkbox gathering, imo. I see no reason to delay this MSC.
@mscbot fcp merge
Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:
Concerns:
Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for information about what commands tagged team members can give me.
... and because I haven't sent enough comments in the last few minutes: the deprecation requirements can be clarified concurrent to checkbox gathering, imo. I see no reason to delay this MSC.
Just for clarification as I haven't done this before, I think this is saying its fine to update the proposal based on the comments whilst SCT members are looking at it?
Updated taking all of the comments above into consideration.
... and because I haven't sent enough comments in the last few minutes: the deprecation requirements can be clarified concurrent to checkbox gathering, imo. I see no reason to delay this MSC.
Just for clarification as I haven't done this before, I think this is saying its fine to update the proposal based on the comments whilst SCT members are looking at it?
Yes, sorry. The proposal can be updated in all kinds of ways up until Final Comment Period (FCP) actually starts - when 8/10 people check their boxes and no concerns are formally raised. Things which SCT members believe should prevent acceptance of the MSC are raised via @mscbot concern
. Everything else is non-blocking, though may still feel important to address.
(though please avoid force pushing, as it makes review harder. We squash all the commits down to a single commit upon acceptance)
My bad, good to know you squash 👍
@mscbot concern outstanding comments
@mscbot resolve outstanding comments
:bell: This is now entering its final comment period, as per the review above. :bell:
The final comment period, with a disposition to merge, as per the review above, is now complete.
ironically, i just found a permalink indexed by room alias in the wild: https://github.com/element-hq/element-web/issues/2150#issue-176068929
merged! :tada:
Rendered
FCP tickyboxes