MSC4163: Make ACLs apply to EDUs

matrix-org / matrix-spec-proposals

Proposals for changes to the matrix specification

Apache License 2.0

982 stars 374 forks source link

MSC4163: Make ACLs apply to EDUs #4163

Closed Kladki closed 1 month ago

Kladki commented 2 months ago

Rendered

Implementations:

Conduwuit
- Typing indicators: https://github.com/girlbossceo/conduwuit/commit/4f0006d18a51b23eb826313b36af1a2586af98fe
- Read receipts: https://github.com/girlbossceo/conduwuit/commit/b8ec763a7cfe009728df45900a0fc4033a30f399

Signed-off-by: Matthias Ahouansou matthias@ahouansou.cz

FCP tickyboxes

clokep commented 2 months ago

I think this is pretty straightforward, has an implementation in conduwuit and makes sense from what ACLs are meant to do.

@mscbot fcp merge

mscbot commented 2 months ago

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

[x] @clokep
[x] @dbkr
[x] @uhoreg
[x] @turt2live
[ ] @ara4n
[x] @anoadragon453
[x] @richvdh
[x] @tulir
[ ] @erikjohnston
[x] @KitsuneRal

Concerns:

~~general clarity~~

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

turt2live commented 2 months ago

@mscbot concern general clarity

turt2live commented 1 month ago

@Kladki you'll also need to sign-off your changes before we're able to accept this. Currently only 1/12 commits are signed off. It may be best to sign off using a comment or the PR description.

turt2live commented 1 month ago

@mscbot resolve general clarity

mscbot commented 1 month ago

:bell: This is now entering its final comment period, as per the review above. :bell:

mscbot commented 1 month ago

The final comment period, with a disposition to merge, as per the review above, is now complete.