search

matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
171 stars 91 forks source link

Add support for `$ref` URIs containing fragments in OpenAPI definitions and JSON schemas #1751

Closed zecakeh closed 3 months ago

zecakeh commented 3 months ago

Based on #1745.

There is a first commit to add support for fragments in $ref URIs, to solve (simple) JSON Pointers. It also adds support for Reference Objects for OpenAPI request parameters and responses.

Preview: https://pr1751--matrix-spec-previews.netlify.app

richvdh commented 3 months ago

oh no :facepalm:

This is the same thing as I did in https://github.com/matrix-org/matrix-spec/pull/1749 :(

zecakeh commented 3 months ago

I saw that 5 minutes ago, well it is kind of a completely different approach for the same purpose though

richvdh commented 3 months ago

@zecakeh As I've written over at #1749, this approach seems sensible, but I'd like to land it independently of #1745. Could you rebase it without that?

zecakeh commented 3 months ago

Alright, I removed the commit with the OpenAPI definition change. I added a commit to also support refs with fragments in the CI scripts.