matrix-org / matrix-spec

The Matrix protocol specification
Apache License 2.0
171 stars 91 forks source link

Do not use `title` for objects containing only `additionalProperties` or `patternProperties` #1801

Closed zecakeh closed 2 months ago

zecakeh commented 2 months ago

Previously, titles would appear that do not link to a subschema definition. It would also mean that named subschemas would appear without being clearly referenced.

Now, the type clearly shows the nesting of objects and subschema definitions should be clearly referenced.

Examples:

Before:

image

After:

Capture d’écran du 2024-04-24 12-31-37

Before:

image

After:

image

[Before]():

image

After:

image

Alternatively, we could just remove the title from the objects manually, allowing us to show a title when we really want to.

The rendered types can be improved later by using formats as introduced in #1796.

Preview: https://pr1801--matrix-spec-previews.netlify.app